-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose object imports #874
Compose object imports #874
Conversation
This is amazing! It's exactly what I miss to convert to Android Compose objects |
Really need this. Is there a reason it was never merged? |
+1 @martymiller Ideally the imports should be automatically imported from the classes and functions used on whether the applied transforms actually need. However, at the moment the current code hardcodes 2 imports
I think this change, although it won't reach the desired goal, it will improve the current code allowing to import more than the 2 hardcoded imports. |
@dbanksdesign can we request an approve for this? in order to integrate this feature? |
Not really, we are waiting for an approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Apologies for the lateness of this review, been very busy, but trying to dig through PRs and issues now. Thank you for understanding.
Issue #, if available: Selectively import on compose class was not available
Description of changes:
Added a formatHelper for import option + added map function in the compose template
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.