Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing TypeScript types #545

Closed
yoniholmes opened this issue Feb 19, 2021 · 1 comment
Closed

Missing TypeScript types #545

yoniholmes opened this issue Feb 19, 2021 · 1 comment

Comments

@yoniholmes
Copy link
Contributor

Hello!

Thanks so much for sharing this library, nice work!

I recently tried out using StyleDictionary with TypeScript (on the 3.0 brach), but noticed some missing types. Those are:

  1. parsers & transform on the Config interface. This is causing a type error in the component-cti example.
  2. registerParser doesn't have any types defined.
  3. The Transform options are marked as required, but, again, in the component-cti example, these aren't defined, so this is causing a type error.

I'm raising a PR to address these – I thought it best to track these in a ticket.
@yoniholmes yoniholmes mentioned this issue Feb 19, 2021
Merged
dbanksdesign pushed a commit that referenced this issue Feb 27, 2021
@yoniholmes
fix(types): introduce parser, update config, optional transform optio…
0042354 
…ns (#546)

Fixes #545
* Add parsers & transform to the Config interface.
* Add types for registerParser
* Make options optional in the 3 Transform types ( NameTransform | ValueTransform | AttributeTransform)
@dbanksdesign
Copy link
Member

Thank you for this fix @yoniholmes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoniholmes @dbanksdesign