Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Stylus format #526

Closed
klausbayrhammer opened this issue Feb 1, 2021 · 3 comments
Closed

Support for Stylus format #526

klausbayrhammer opened this issue Feb 1, 2021 · 3 comments

Comments

@klausbayrhammer
Copy link
Contributor

Some of our internal projects use Stylus as a preprocessor, and we've written a custom formatter to support this (which works great).

Since stylus is relatively popular we would happily contribute it. However we were not sure if based on the "what should be included" section in the contributing guidelines stylus support is something you would like to see within the style-dictionary.

@dbanksdesign
Copy link
Member

Stylus would definitely be something we would see within Style Dictionary. That section in the contribution doc is mainly so we don't get non-generic formats, but we always want to add support for languages. If you would like to contribute that, take a look at the Less, SCSS, and CSS formats. I'm not as familiar with Stylus, I assume we don't need to add any new transforms to support Stylus.

klausbayrhammer added a commit to klausbayrhammer/style-dictionary that referenced this issue Feb 2, 2021
Although leading dollar signs are not mandatory for stylus variables
there is a trend to having this, so I also included it in this PR.

see https://gist.github.com/zspecza/7220997#why

refs amzn#526
klausbayrhammer added a commit to klausbayrhammer/style-dictionary that referenced this issue Feb 2, 2021
Although leading dollar signs are not mandatory for stylus variables
there is a trend to having this, so I also included it in this PR.

see https://gist.github.com/zspecza/7220997#why

refs amzn#526
klausbayrhammer added a commit to klausbayrhammer/style-dictionary that referenced this issue Feb 2, 2021
Although leading dollar signs are not mandatory for stylus variables
there is a trend to having this, so I also included it in this PR.

see https://gist.github.com/zspecza/7220997#why

refs amzn#526
klausbayrhammer added a commit to klausbayrhammer/style-dictionary that referenced this issue Feb 9, 2021
Although leading dollar signs are not mandatory for stylus variables
there is a trend to having this, so I also included it in this PR.

see https://gist.github.com/zspecza/7220997#why

refs amzn#526
@chazzmoney
Copy link
Collaborator

This will be included in the next release candidate for 3.0. Once that is done (probably next Monday, Feb 15th, 2021), you can try it out using:

npm install --save-dev style-dictionary@next

@dbanksdesign
Copy link
Member

Just released the next release candidate, it should now be available with the next tag like @chazzmoney said above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants