Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formats): add file object to formatter method #439

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Conversation

dbanksdesign
Copy link
Member

Issue #, if available: #370

Description of changes: Passing the file object to the formatter function so it can be accessed as an argument rather than being bound to this. I kept the binding as-is to ensure backwards compatibility though.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dbanksdesign dbanksdesign changed the base branch from master to 3.0 July 20, 2020 16:57
@chazzmoney
Copy link
Collaborator

I'm good with this. It does change a couple function signatures, but they are all internal. Do you think this should be a 3.0 thing?

@dbanksdesign
Copy link
Member Author

Yea this should be 3.0 I think.

@chazzmoney
Copy link
Collaborator

LGTM! :shipit:

@chazzmoney chazzmoney merged commit 1481c46 into 3.0 Nov 7, 2020
@dbanksdesign dbanksdesign deleted the fix-370 branch March 12, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants