Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass file as an argument in formatter #370

Closed
dbanksdesign opened this issue Jan 8, 2020 · 2 comments
Closed

Pass file as an argument in formatter #370

dbanksdesign opened this issue Jan 8, 2020 · 2 comments
Labels
Core Architecture This is an issue related to the core architecture of Style Dictionary format refactor
Milestone
3.0

Comments

@dbanksdesign
Copy link
Member

Based on the conversation in #363 it would probably make more sent to pass the file object as an argument in the formatter function rather than bind this to it. It could be done in a backwards-compatible way by sending one more argument and keeping the binding in place.
@dbanksdesign dbanksdesign added this to the 3.0 milestone Jun 4, 2020
@dbanksdesign dbanksdesign added Core Architecture This is an issue related to the core architecture of Style Dictionary format refactor labels Jun 4, 2020
@dbanksdesign dbanksdesign mentioned this issue Jun 19, 2020
Merged
@dbanksdesign
Copy link
Member Author

The code is merged in, we just need to update the documentation in the 3.0 branch to remove the mention of this and instead use the file object.

@dbanksdesign
Copy link
Member Author

Closing this as it is in 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Architecture This is an issue related to the core architecture of Style Dictionary format refactor
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@dbanksdesign