feat(attribute/cti): make attribute/cti respect manually set attributes #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chazzmoney
reviewed
Apr 17, 2020
lib/common/transforms.js
Outdated
Comment on lines
79
to
81
| prop.path.forEach((leaf, i) => { | ||
| generatedAttrs[attrNames[i]] = leaf; | ||
| }); |
There was a problem hiding this comment.
if prop.path.length > attrNames.length, then line 80 will set generatedAttrs[undefined] to the last leaf value in prop.path.
This would be new behavior. Maybe the loop should be forced to only run a maximum of 5 times?
There was a problem hiding this comment.
Great catch. I updated the loop to terminate if either array runs out of values so that you can change the length of the attrNames array in the future. I'll commit that now.
|
Hi Tony, Thank you for this! I agree that this would be a better situation than our current setup. Can you check out the comment I posted? Its just a thought about managing the length of the two arrays being used together. Thanks! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 414
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.