feat(attribute/cti): attribute/cti should respect manually set attrib…

…utes (#415) fix #414
amzn · Sep 28, 2020 · 8ab28cc · 8ab28cc
1 parent 6f0ac4d
commit 8ab28cc
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 6 deletions.
diff --git a/__tests__/common/transforms.test.js b/__tests__/common/transforms.test.js
@@ -169,6 +169,49 @@ describe('common', () => {
       });
     });
 
+    describe('transform', () => {
+      describe('attribute/cti', () => {
+
+        const prop = {
+          "path": ["color", "background", "button", "primary", "active", "extra"],
+        };
+        const propShort = { "path": ["color", "primary"] };
+        const propOverride = {
+          "path": ["button", "primary", "border", "width"],
+          "attributes": { "category": "size", "component": "button" }
+        };
+
+        const attrs = transforms["attribute/cti"].transformer(prop);
+        const attrsShort = transforms["attribute/cti"].transformer(propShort);
+        const attrsOverride = transforms["attribute/cti"].transformer(propOverride);
+
+        it('should assign attributes correctly', () => {
+          expect(attrs).toEqual({
+            "category": "color",
+            "type": "background",
+            "item": "button",
+            "subitem": "primary",
+            "state": "active"
+          });
+        });
+
+        it('should not assign path props when path is short' , () => {
+          expect(attrsShort).toEqual({
+            "category": "color",
+            "type": "primary"
+          });
+        });
+
+        it('should leave other attributes alone', () => {
+          expect(attrsOverride).toHaveProperty('component', 'button');
+        });
+
+        it('should not override previously assigned path attributes', () => {
+          expect(attrsOverride).toHaveProperty('category', 'size');
+        });
+      });
+    });
+
     describe('color/hex', () => {
       it('should handle hex colors', () => {
         var value = transforms["color/hex"].transformer({

diff --git a/lib/common/transforms.js b/lib/common/transforms.js
@@ -75,13 +75,16 @@ module.exports = {
   'attribute/cti': {
     type: 'attribute',
     transformer: function(prop) {
-      return {
-        category: prop.path[0],
-        type:     prop.path[1],
-        item:     prop.path[2],
-        subitem:  prop.path[3],
-        state:    prop.path[4]
+
+      const attrNames = ['category', 'type', 'item', 'subitem', 'state'];
+      const originalAttrs = prop.attributes || {};
+      const generatedAttrs =  {}
+
+      for(let i=0; i<prop.path.length && i<attrNames.length; i++) {
+        generatedAttrs[attrNames[i]] = prop.path[i];
       }
+
+      return Object.assign(generatedAttrs, originalAttrs);
     }
   },