Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Code #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactored Code #11

wants to merge 2 commits into from

Conversation

gitvinit
Copy link

@gitvinit gitvinit commented Mar 6, 2017

Refactored code to remove redundancies and implement code improvements

Refactored code to remove redundancies and implement code improvements
Copy link

@vaclavholusa-LTD vaclavholusa-LTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be really accepted and merged to the library

@bjguillot
Copy link

Thanks for the reminder on this. We will need to review and check it with our internal integration tests. There appear to be some conflicts that would need to be resolved as well.

@gitvinit
Copy link
Author

@bjguillot I have resolved the merge conflicts let me know if any other changes are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants