comment out unused order types #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That would be awesome to merge this PR as it's currently blocking compilation for typescript users in strict mode. If you want to understand why, here is an explanation. What needs to be achieved to move forward with this PR? |
|
@juliensnz @Goldbird-Solutions, sorry for being a bit late on this, merged and published in v.0.7.2. |
|
Awesome! Thanks a lot :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unused typescript intefaces 'OrderItemsBuyerInfoList' and 'OrderItemsList' in
lib/typings/operations/orders.tsbreak our git pipeline. I commented them out for now, until you need them.