fix: Change databuilder search data extractors to publish name
in user document.
#2274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the search data databuilder extractors to extract a
name
field, for publishing to elasticsearch.Currently, the user document schema in elasticsearch expects a
name
keyword, which is the primary field for searching users. (Expected from Databuilder publish, and expected from search service)Motivation and Context
The change is required because currently the elasticsearch query does not use the
name
field to create better matches for search results, and instead is likely just using first/last and key of the user. This is fine when searching for just first or last, but when searching both the search results currently aren't great for this reason.This is actually fixed in the example query (PR) for posting from neo4j to elasticsearch, but this query is never used.
How Has This Been Tested?
This has only been tested with the neo4j_search_data_extractor, and not the other extractors. Testing was done by:
localhost:9200
and inspecting document valuesDocumentation
No change in documentation
CheckList
Believe this fix has no need for:
Updates Documentation and DocstringsAdds testsAdds instrumentation (logs, or UI events)