Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add method get_resources_using_table to metadata gremlin_proxy #2223

Merged

Conversation

sihaotan4
Copy link
Contributor

Description

Implemented method get_resources_using_table in gremlin_proxy.py.
This method is a gremlin implementation of the similar method found in neo4j_proxy.py line 1892.

The method retrieves the list of dashboards that are using a specific table, in the form of DashboardSummary objects.

Motivation and Context

This function was not implemented for Gremlin (for users using AWS Neptune instead of neo4j).

How Has This Been Tested?

Currently, there are no existing unit tests for gremlin proxy. But this new function has been tested internally with our Neptune server.

Documentation

Function docstring added.

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

@sihaotan4 sihaotan4 requested a review from a team as a code owner December 20, 2023 16:45
@boring-cyborg boring-cyborg bot added the area:metadata From the metadata folder label Dec 20, 2023
@kristenarmes kristenarmes merged commit 505a840 into amundsen-io:main Dec 20, 2023
8 checks passed
@sihaotan4 sihaotan4 deleted the implement_get_resources_using_table branch December 20, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metadata From the metadata folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants