-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Minor styling fixes for Report an issue modal #1756
fix: Minor styling fixes for Report an issue modal #1756
Conversation
Signed-off-by: Kristen Armes <[email protected]>
frontend/amundsen_application/static/js/pages/TableDetailPage/ReportTableIssue/styles.scss
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/pages/TableDetailPage/ReportTableIssue/styles.scss
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/pages/TableDetailPage/ReportTableIssue/styles.scss
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristen Armes <[email protected]>
@@ -13,16 +14,16 @@ $submit-row-gap: 15%; | |||
display: block; | |||
height: auto; | |||
left: 25px; | |||
min-height: 300px; | |||
padding: 32px; | |||
min-height: $modal-size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you notice this wasn't the same number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did, I thought you meant when you said "the same as min-height" to just make them the same since it was a minimum value and didn't end up changing the height. But I can go ahead and change it to be their own values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry for the confusion!
If they looks the same, go ahead with this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I will leave it then! The modal looks like it is always taller than the width with the contents it has anyway
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]> Signed-off-by: Ozan Dogrultan <[email protected]>
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]> Signed-off-by: Zachary Ruiz <[email protected]>
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]>
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]>
Signed-off-by: Kristen Armes [email protected]
Summary of Changes
Minor fixes for the Report an issue modal, including fixing the specificity of the close button and increasing the z-index so the modal will appear in front of everything.
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.