fix: Minor styling fixes for Report an issue modal #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristen Armes <[email protected]>
kristenarmes
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd and
dechoma
as code owners
Golodhros
approved these changes
Mar 8, 2022
frontend/amundsen_application/static/js/pages/TableDetailPage/ReportTableIssue/styles.scss
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/pages/TableDetailPage/ReportTableIssue/styles.scss
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/pages/TableDetailPage/ReportTableIssue/styles.scss
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristen Armes <[email protected]>
Golodhros
reviewed
Mar 8, 2022
| @@ -13,16 +14,16 @@ $submit-row-gap: 15%; | |||
| display: block; | |||
| height: auto; | |||
| left: 25px; | |||
| min-height: 300px; | |||
| padding: 32px; | |||
| min-height: $modal-size; | |||
There was a problem hiding this comment.
Did you notice this wasn't the same number?
There was a problem hiding this comment.
I did, I thought you meant when you said "the same as min-height" to just make them the same since it was a minimum value and didn't end up changing the height. But I can go ahead and change it to be their own values
There was a problem hiding this comment.
Ah, sorry for the confusion!
If they looks the same, go ahead with this!
There was a problem hiding this comment.
Sounds good, I will leave it then! The modal looks like it is always taller than the width with the contents it has anyway
ozandogrultan
pushed a commit
to deliveryhero/amundsen
that referenced
this pull request
Apr 28, 2022
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]> Signed-off-by: Ozan Dogrultan <[email protected]>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 3, 2022
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]> Signed-off-by: Zachary Ruiz <[email protected]>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
* Minor styling fixes for Report an issue modal Signed-off-by: Kristen Armes <[email protected]> * Using more variables Signed-off-by: Kristen Armes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristen Armes [email protected]
Summary of Changes
Minor fixes for the Report an issue modal, including fixing the specificity of the close button and increasing the z-index so the modal will appear in front of everything.
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.