-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delta table partition watermarks #1694
Merged
Merged
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8954e87
Install pyspark for dev work
harmw c32cc1f
Read watermarks for Delta tables
harmw 9455b56
Include tests
harmw d6e6d95
More proper watermark yielding
harmw 1398b88
Select the partition_column
harmw e3eaaf8
Cut the line length
harmw e821fae
Only process partitions of a workable type
harmw 323db25
Updated tests
harmw 200e64b
Oops, the .first() returns a Row object
harmw 33c8676
Merge branch 'main' into more-delta-lake
harmw 0db83c9
Wrap this extraction in a try/except
harmw ad0280e
Flake8 fixes
harmw 06b9fc3
Simplicity
harmw 94766f9
Revert "Simplicity"
harmw b50d3d7
Simplicity in return typing
harmw 7f2c191
There is no complexity here :jedi_hand_wave:
harmw f4ccec8
Pass the mypy
harmw d99bc17
Fix the return type here, finally
harmw 1c4ab7d
Fix import sorting order
harmw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,4 @@ pytest-cov>=2.12.0 | |
pytest-env>=0.6.2 | ||
pytest-mock>=3.6.1 | ||
typed-ast>=1.4.3 | ||
pyspark==3.0.1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does it need to be a hard pin or will this work with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought we had pyspark deps in setup.py? |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in regards to comment on line 435 I would just do: