Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook is broken #973

Closed
Golodhros opened this issue Mar 26, 2021 · 3 comments
Closed

Storybook is broken #973

Golodhros opened this issue Mar 26, 2021 · 3 comments
Labels
status:completed Issue is completed and on master type:bug An unexpected problem or unintended behavior

Comments

@Golodhros
Copy link
Member

After updating to Webpack 5, Storybook got broken as it wasn't supporting it yet.

Expected Behavior

Storybook should be running in the local dev environment

Possible Solution

They just released experimental support of Webpack 5 (https://storybook.js.org/blog/storybook-for-webpack-5/). There is a Github issue tracking all this (storybookjs/storybook#9216 (comment)).

I started the work in https://github.com/amundsen-io/amundsenfrontendlibrary/tree/WAITING-storybook-webpack-5-issue-fix, happy if anybody can pick it up and take it through the finish line.

Steps to Reproduce

  1. Run npm start storybook
  2. See the build breaking
@Golodhros Golodhros added type:bug An unexpected problem or unintended behavior Project: Frontend status:in_progress Issue that is being worked on right now labels Mar 26, 2021
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
…undsen-io#973)

Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. **This update includes a security fix.**
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dorianj
Copy link
Contributor

dorianj commented Apr 29, 2021

I worked on this for a while and just couldn't get it working, either... I eventually got stuck on an issue where core-js modules wouldn't load:

Did you mean 'keys.js'?
BREAKING CHANGE: The request '../../core-js/object/keys' failed to resolve only because it was resolved as fully specified
(probably because the origin is a '*.mjs' file or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.

I wonder if there's anything in our normal build configuration that could be simplified/removed, which would then make this easier?

feng-tao pushed a commit that referenced this issue May 7, 2021
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. **This update includes a security fix.**
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@stale
Copy link

stale bot commented May 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label May 14, 2021
@dorianj dorianj removed the stale label May 14, 2021
@stale
Copy link

stale bot commented May 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label May 28, 2021
@Golodhros Golodhros added keep fresh Disables stalebot from closing an issue and removed stale labels Jun 1, 2021
@Golodhros Golodhros added status:needs_votes Issue or bug fix that needs support from the community to be considered and removed status:in_progress Issue that is being worked on right now labels Oct 11, 2021
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
…undsen-io#973)

Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. **This update includes a security fix.**
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
…undsen-io#973)

Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. **This update includes a security fix.**
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@Golodhros Golodhros added status:completed Issue is completed and on master and removed keep fresh Disables stalebot from closing an issue status:needs_votes Issue or bug fix that needs support from the community to be considered labels Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:completed Issue is completed and on master type:bug An unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants