fix: add more child types of complex Metadata

This enables `force-dev-tool changeset create` to handle e.g. `customSettingAccesses ` of `CustomObject`. Closes #218
amtrack · May 12, 2020 · aa318e6 · aa318e6
1 parent 5531c8c
commit aa318e6
Show file tree

Hide file tree

Showing 10 changed files with 1,443 additions and 30 deletions.
diff --git a/lib/describe-metadata-service.js b/lib/describe-metadata-service.js
@@ -4,11 +4,6 @@ var _ = require('underscore');
 var path = require('path');
 
 var childTypes = [{
-	xmlName: 'ActionOverride',
-	tagName: 'actionOverrides',
-	parent: 'CustomObject',
-	key: 'actionName'
-}, {
 	xmlName: 'AssignmentRule',
 	tagName: 'assignmentRule',
 	parent: 'AssignmentRules',
@@ -20,27 +15,44 @@ var childTypes = [{
 	parent: 'AutoResponseRules',
 	key: 'fullName',
 	isNamed: true
+}, {
+	xmlName: 'ActionOverride',
+	tagName: 'actionOverrides',
+	parent: 'CustomObject',
+	key: 'actionName'
+}, {
+	xmlName: 'BusinessProcess',
+	tagName: 'businessProcesses',
+	parent: 'CustomObject',
+	key: 'fullName',
+	isNamed: true
+}, {
+	xmlName: 'CompactLayout',
+	tagName: 'compactLayouts',
+	parent: 'CustomObject',
+	key: 'fullName',
+	isNamed: true
 }, {
 	xmlName: 'CustomField',
 	tagName: 'fields',
 	parent: 'CustomObject',
 	key: 'fullName',
 	isNamed: true
 }, {
-	xmlName: 'Index',
-	tagName: 'indexes',
+	xmlName: 'FieldSet',
+	tagName: 'fieldSets',
 	parent: 'CustomObject',
 	key: 'fullName',
 	isNamed: true
 }, {
-	xmlName: 'BusinessProcess',
-	tagName: 'businessProcesses',
+	xmlName: 'Index',
+	tagName: 'indexes',
 	parent: 'CustomObject',
 	key: 'fullName',
 	isNamed: true
 }, {
-	xmlName: 'CompactLayout',
-	tagName: 'compactLayouts',
+	xmlName: 'ListView',
+	tagName: 'listViews',
 	parent: 'CustomObject',
 	key: 'fullName',
 	isNamed: true
@@ -51,20 +63,25 @@ var childTypes = [{
 	key: 'fullName',
 	isNamed: true
 }, {
-	xmlName: 'WebLink',
-	tagName: 'webLinks',
+	xmlName: 'SharingReason',
+	tagName: 'sharingReasons',
 	parent: 'CustomObject',
 	key: 'fullName',
 	isNamed: true
+}, {
+	xmlName: 'SharingRecalculation',
+	tagName: 'sharingRecalculations',
+	parent: 'CustomObject',
+	key: 'className'
 }, {
 	xmlName: 'ValidationRule',
 	tagName: 'validationRules',
 	parent: 'CustomObject',
 	key: 'fullName',
 	isNamed: true
 }, {
-	xmlName: 'SharingReason',
-	tagName: 'sharingReasons',
+	xmlName: 'WebLink',
+	tagName: 'webLinks',
 	parent: 'CustomObject',
 	key: 'fullName',
 	isNamed: true
@@ -80,18 +97,6 @@ var childTypes = [{
 	parent: 'SharingRules',
 	key: 'fullName',
 	isNamed: true
-}, {
-	xmlName: 'ListView',
-	tagName: 'listViews',
-	parent: 'CustomObject',
-	key: 'fullName',
-	isNamed: true
-}, {
-	xmlName: 'FieldSet',
-	tagName: 'fieldSets',
-	parent: 'CustomObject',
-	key: 'fullName',
-	isNamed: true
 }, {
 	xmlName: 'WorkflowFieldUpdate',
 	tagName: 'fieldUpdates',
@@ -158,21 +163,31 @@ var childTypes = [{
 	tagName: 'applicationVisibilities',
 	parent: 'Profile',
 	key: 'application'
+}, {
+	xmlName: 'ProfileCategoryGroupVisibility',
+	tagName: 'categoryGroupVisibilities',
+	parent: 'Profile',
+	key: 'dataCategoryGroup'
 }, {
 	xmlName: 'ProfileApexClassAccess',
 	tagName: 'classAccesses',
 	parent: 'Profile',
 	key: 'apexClass'
 }, {
-	xmlName: 'ProfileApexPageAccess',
-	tagName: 'pageAccesses',
+	xmlName: 'ProfileCustomMetadataTypeAccess',
+	tagName: 'customMetadataTypeAccesses',
 	parent: 'Profile',
-	key: 'apexPage'
+	key: 'name'
 }, {
 	xmlName: 'ProfileCustomPermissions',
 	tagName: 'customPermissions',
 	parent: 'Profile',
 	key: 'name'
+}, {
+	xmlName: 'ProfileCustomSettingAccesses',
+	tagName: 'customSettingAccesses',
+	parent: 'Profile',
+	key: 'name'
 }, {
 	xmlName: 'ProfileExternalDataSourceAccess',
 	tagName: 'externalDataSourceAccesses',
@@ -194,6 +209,16 @@ var childTypes = [{
 	tagName: 'objectPermissions',
 	parent: 'Profile',
 	key: 'object'
+}, {
+	xmlName: 'ProfileApexPageAccess',
+	tagName: 'pageAccesses',
+	parent: 'Profile',
+	key: 'apexPage'
+}, {
+	xmlName: 'ProfileActionOverride',
+	tagName: 'profileActionOverrides',
+	parent: 'Profile',
+	key: 'actionName'
 }, {
 	xmlName: 'ProfileRecordTypeVisibility',
 	tagName: 'recordTypeVisibilities',

diff --git a/test-functional/data/simple-metadata/profile-custom-settings/expected/package.xml b/test-functional/data/simple-metadata/profile-custom-settings/expected/package.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Package xmlns="http://soap.sforce.com/2006/04/metadata">
+    <types>
+        <members>Admin</members>
+        <name>Profile</name>
+    </types>
+    <version>48.0</version>
+</Package>
diff --git a/test-functional/data/simple-metadata/profile-custom-settings/expected/profiles/Admin.profile b/test-functional/data/simple-metadata/profile-custom-settings/expected/profiles/Admin.profile
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Profile xmlns="http://soap.sforce.com/2006/04/metadata">
+    <customSettingAccesses>
+        <enabled>true</enabled>
+        <name>MyCustomSetting__c</name>
+    </customSettingAccesses>
+</Profile>
diff --git a/...ctional/data/simple-metadata/profile-custom-settings/v0/objects/MyCustomSetting__c.object b/...ctional/data/simple-metadata/profile-custom-settings/v0/objects/MyCustomSetting__c.object
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
+    <customSettingsType>Hierarchy</customSettingsType>
+    <enableFeeds>false</enableFeeds>
+    <label>My Custom Setting</label>
+    <visibility>Public</visibility>
+</CustomObject>
diff --git a/test-functional/data/simple-metadata/profile-custom-settings/v0/package.xml b/test-functional/data/simple-metadata/profile-custom-settings/v0/package.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Package xmlns="http://soap.sforce.com/2006/04/metadata">
+    <types>
+        <members>MyCustomSetting__c</members>
+        <name>CustomObject</name>
+    </types>
+    <types>
+        <members>Admin</members>
+        <name>Profile</name>
+    </types>
+    <version>48.0</version>
+</Package>