Fixed bugs in explorer redirection (opensearch-project#1609)

* allow for redirection in associated objects skipping indices Signed-off-by: Paul Sebastian <[email protected]> * redirection in datasources table implemented Signed-off-by: Paul Sebastian <[email protected]> * moderate s3 callout changes Signed-off-by: Paul Sebastian <[email protected]> * lint complaint Signed-off-by: Paul Sebastian <[email protected]> * update snap Signed-off-by: Paul Sebastian <[email protected]> * fix discover to explorer url redirection Signed-off-by: Paul Sebastian <[email protected]> * include glue cache s3 callout Signed-off-by: Paul Sebastian <[email protected]> * update snapshot Signed-off-by: Paul Sebastian <[email protected]> * expand text area max length Signed-off-by: Paul Sebastian <[email protected]> * s3 no results page updated implementation Signed-off-by: Paul Sebastian <[email protected]> * open up acceleration flyout when direct query visualization Signed-off-by: Paul Sebastian <[email protected]> * update snapshots Signed-off-by: Paul Sebastian <[email protected]> * update one last snap Signed-off-by: Paul Sebastian <[email protected]> * fix lint complaint for a file i didnt even touch Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]>
amsiglan · Mar 25, 2024 · faf9c23 · faf9c23
1 parent 263542b
commit faf9c23
Show file tree

Hide file tree

Showing 20 changed files with 435 additions and 269 deletions.
diff --git a/common/constants/autocomplete.ts b/common/constants/autocomplete.ts
@@ -6,6 +6,8 @@
 
 import { BaseItem } from '@algolia/autocomplete-core';
 
+export const textAreaMaxLength = 16384;
+
 export const firstCommand = [{ label: 'source' }];
 
 export const pipeCommands = [

diff --git a/common/types/data_connections.ts b/common/types/data_connections.ts
@@ -35,11 +35,12 @@ export interface Acceleration {
 }
 
 export interface AssociatedObject {
+  tableName: string;
   datasource: string;
   id: string;
   name: string;
   database: string;
-  type: AccelerationIndexType | 'table';
+  type: AssociatedObjectIndexType;
   accelerations: CachedAcceleration[];
   columns?: CachedColumn[];
 }
@@ -86,6 +87,8 @@ export interface AsyncApiResponse {
 
 export type PollingCallback = (statusObj: AsyncApiResponse) => void;
 
+export type AssociatedObjectIndexType = AccelerationIndexType | 'table';
+
 export type AccelerationIndexType = 'skipping' | 'covering' | 'materialized';
 
 export type LoadCacheType = 'databases' | 'tables' | 'accelerations' | 'tableColumns';

diff --git a/public/components/application_analytics/__tests__/__snapshots__/create.test.tsx.snap b/public/components/application_analytics/__tests__/__snapshots__/create.test.tsx.snap
@@ -307,7 +307,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -1561,7 +1561,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"
@@ -2756,7 +2756,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -3924,7 +3924,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"
@@ -5151,7 +5151,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -6319,7 +6319,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"
@@ -7543,7 +7543,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -8672,7 +8672,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"
@@ -9859,7 +9859,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -10993,7 +10993,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"
@@ -12186,7 +12186,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -13354,7 +13354,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"
@@ -14581,7 +14581,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -15749,7 +15749,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"
@@ -16978,7 +16978,7 @@ Object {
                                       data-test-subj="searchAutocompleteTextArea"
                                       enterkeyhint="search"
                                       id="autocomplete-textarea"
-                                      maxlength="512"
+                                      maxlength="16384"
                                       placeholder="Enter query"
                                       rows="6"
                                       spellcheck="false"
@@ -18232,7 +18232,7 @@ Object {
                                     data-test-subj="searchAutocompleteTextArea"
                                     enterkeyhint="search"
                                     id="autocomplete-textarea"
-                                    maxlength="512"
+                                    maxlength="16384"
                                     placeholder="Enter query"
                                     rows="6"
                                     spellcheck="false"

diff --git a/public/components/application_analytics/__tests__/__snapshots__/log_config.test.tsx.snap b/public/components/application_analytics/__tests__/__snapshots__/log_config.test.tsx.snap
@@ -512,7 +512,7 @@ exports[`Log Config component renders empty log config 1`] = `
                                         disabled={false}
                                         enterKeyHint="search"
                                         id="autocomplete-textarea"
-                                        maxLength={512}
+                                        maxLength={16384}
                                         onBlur={[Function]}
                                         onChange={[Function]}
                                         onClick={[Function]}
@@ -543,7 +543,7 @@ exports[`Log Config component renders empty log config 1`] = `
                                             disabled={false}
                                             enterKeyHint="search"
                                             id="autocomplete-textarea"
-                                            maxLength={512}
+                                            maxLength={16384}
                                             onBlur={[Function]}
                                             onChange={[Function]}
                                             onClick={[Function]}
@@ -1136,7 +1136,7 @@ exports[`Log Config component renders with query 1`] = `
                                         disabled={false}
                                         enterKeyHint="search"
                                         id="autocomplete-textarea"
-                                        maxLength={512}
+                                        maxLength={16384}
                                         onBlur={[Function]}
                                         onChange={[Function]}
                                         onClick={[Function]}
@@ -1167,7 +1167,7 @@ exports[`Log Config component renders with query 1`] = `
                                             disabled={false}
                                             enterKeyHint="search"
                                             id="autocomplete-textarea"
-                                            maxLength={512}
+                                            maxLength={16384}
                                             onBlur={[Function]}
                                             onChange={[Function]}
                                             onClick={[Function]}

diff --git a/public/components/common/search/__tests__/__snapshots__/search.test.tsx.snap b/public/components/common/search/__tests__/__snapshots__/search.test.tsx.snap
@@ -250,7 +250,7 @@ exports[`Explorer Search component renders basic component 1`] = `
                             data-test-subj="searchAutocompleteTextArea"
                             enterKeyHint="search"
                             id="autocomplete-textarea"
-                            maxLength={512}
+                            maxLength={16384}
                             onBlur={[Function]}
                             onChange={[Function]}
                             onClick={[Function]}
@@ -280,7 +280,7 @@ exports[`Explorer Search component renders basic component 1`] = `
                                 data-test-subj="searchAutocompleteTextArea"
                                 enterKeyHint="search"
                                 id="autocomplete-textarea"
-                                maxLength={512}
+                                maxLength={16384}
                                 onBlur={[Function]}
                                 onChange={[Function]}
                                 onClick={[Function]}

diff --git a/public/components/common/search/autocomplete.tsx b/public/components/common/search/autocomplete.tsx
@@ -9,7 +9,7 @@ import { EuiFieldText, EuiTextArea } from '@elastic/eui';
 import $ from 'jquery';
 import DSLService from 'public/services/requests/dsl';
 import React, { useEffect, useMemo, useState } from 'react';
-import { AutocompleteItem } from '../../../../common/constants/autocomplete';
+import { AutocompleteItem, textAreaMaxLength } from '../../../../common/constants/autocomplete';
 import { uiSettingsService } from '../../../../common/utils';
 import { IQueryBarProps } from './search';
 import './search.scss';
@@ -142,6 +142,7 @@ export const Autocomplete = (props: AutocompleteProps) => {
           'data-test-subj': 'searchAutocompleteTextArea',
           placeholder,
           inputElement: null,
+          maxLength: textAreaMaxLength,
         })}
         {...(panelsFilter && { append, fullWidth: true })}
         disabled={isDisabled}

diff --git a/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view.test.tsx.snap b/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view.test.tsx.snap
@@ -191,7 +191,7 @@ exports[`Panels View Component render panel view container and refresh panel 1`]
                     disabled=""
                     enterkeyhint="search"
                     id="autocomplete-textarea"
-                    maxlength="512"
+                    maxlength="16384"
                     placeholder="Use PPL 'where' clauses to add filters on all visualizations [where Carrier = 'OpenSearch-Air']"
                     spellcheck="false"
                     style="margin-top: 0px; height: 18px; padding: 8px;"
@@ -622,7 +622,7 @@ exports[`Panels View Component render panel view so container and reload dashboa
                     disabled=""
                     enterkeyhint="search"
                     id="autocomplete-textarea"
-                    maxlength="512"
+                    maxlength="16384"
                     placeholder="Use PPL 'where' clauses to add filters on all visualizations [where Carrier = 'OpenSearch-Air']"
                     spellcheck="false"
                     style="margin-top: 0px; height: 18px; padding: 8px;"
@@ -1810,7 +1810,7 @@ exports[`Panels View Component renders panel view container with visualizations
                                 enterKeyHint="search"
                                 fullWidth={true}
                                 id="autocomplete-textarea"
-                                maxLength={512}
+                                maxLength={16384}
                                 onBlur={[Function]}
                                 onChange={[Function]}
                                 onClick={[Function]}
@@ -1864,7 +1864,7 @@ exports[`Panels View Component renders panel view container with visualizations
                                           disabled={true}
                                           enterKeyHint="search"
                                           id="autocomplete-textarea"
-                                          maxLength={512}
+                                          maxLength={16384}
                                           onBlur={[Function]}
                                           onChange={[Function]}
                                           onClick={[Function]}
@@ -4043,7 +4043,7 @@ exports[`Panels View Component renders panel view container without visualizatio
                                 enterKeyHint="search"
                                 fullWidth={true}
                                 id="autocomplete-textarea"
-                                maxLength={512}
+                                maxLength={16384}
                                 onBlur={[Function]}
                                 onChange={[Function]}
                                 onClick={[Function]}
@@ -4097,7 +4097,7 @@ exports[`Panels View Component renders panel view container without visualizatio
                                           disabled={true}
                                           enterKeyHint="search"
                                           id="autocomplete-textarea"
-                                          maxLength={512}
+                                          maxLength={16384}
                                           onBlur={[Function]}
                                           onChange={[Function]}
                                           onClick={[Function]}

diff --git a/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view_so.test.tsx.snap b/public/components/custom_panels/__tests__/__snapshots__/custom_panel_view_so.test.tsx.snap
@@ -191,7 +191,7 @@ exports[`Panels View SO Component render panel view container and refresh panel
                     disabled=""
                     enterkeyhint="search"
                     id="autocomplete-textarea"
-                    maxlength="512"
+                    maxlength="16384"
                     placeholder="Use PPL 'where' clauses to add filters on all visualizations [where Carrier = 'OpenSearch-Air']"
                     spellcheck="false"
                     style="margin-top: 0px; height: 18px; padding: 8px;"
@@ -622,7 +622,7 @@ exports[`Panels View SO Component render panel view so container and reload dash
                     disabled=""
                     enterkeyhint="search"
                     id="autocomplete-textarea"
-                    maxlength="512"
+                    maxlength="16384"
                     placeholder="Use PPL 'where' clauses to add filters on all visualizations [where Carrier = 'OpenSearch-Air']"
                     spellcheck="false"
                     style="margin-top: 0px; height: 18px; padding: 8px;"
@@ -1055,7 +1055,7 @@ exports[`Panels View SO Component renders panels view SO container with visualiz
                     disabled=""
                     enterkeyhint="search"
                     id="autocomplete-textarea"
-                    maxlength="512"
+                    maxlength="16384"
                     placeholder="Use PPL 'where' clauses to add filters on all visualizations [where Carrier = 'OpenSearch-Air']"
                     spellcheck="false"
                     style="margin-top: 0px; height: 18px; padding: 8px;"