Nginx Integration Panel Fix: Re-apply link removal (opensearch-projec…

…t#807) * Fix broken nginx data volume panel Signed-off-by: Simeon Widdis <[email protected]> * Re-add sample data Signed-off-by: Simeon Widdis <[email protected]> * Re-apply link fix and update test Signed-off-by: Simeon Widdis <[email protected]> * Re-apply formatting to local_repository.test.ts Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
amsiglan · Aug 3, 2023 · ca5ea39 · ca5ea39
1 parent 4d33d82
commit ca5ea39
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/server/adaptors/integrations/__data__/repository/nginx/nginx-1.0.0.json b/server/adaptors/integrations/__data__/repository/nginx/nginx-1.0.0.json
@@ -5,7 +5,6 @@
     "description": "Nginx HTTP server collector",
     "license": "Apache-2.0",
     "type": "logs",
-    "link": "https://www.nginx.com/",
     "author": "OpenSearch",
     "sourceUrl": "https://github.com/opensearch-project/dashboards-observability/tree/main/server/adaptors/integrations/__data__/repository/nginx/info",
     "statics": {

diff --git a/server/adaptors/integrations/__test__/local_repository.test.ts b/server/adaptors/integrations/__test__/local_repository.test.ts
@@ -6,12 +6,24 @@
 import { Repository } from '../repository/repository';
 import { Integration } from '../repository/integration';
 import path from 'path';
+import * as fs from 'fs/promises';
 
 describe('The local repository', () => {
-  it('Should pass shallow validation for all local integrations.', async () => {
-    const repository: Repository = new Repository(path.join(__dirname, '../__data__/repository'));
-    const integrations: Integration[] = await repository.getIntegrationList();
-    await Promise.all(integrations.map((i) => expect(i.check()).resolves.toBeTruthy()));
+  it('Should only contain valid integration directories or files.', async () => {
+    const directory = path.join(__dirname, '../__data__/repository');
+    const folders = await fs.readdir(directory);
+    await Promise.all(
+      folders.map(async (folder) => {
+        const integPath = path.join(directory, folder);
+        if (!(await fs.lstat(integPath)).isDirectory()) {
+          // If it's not a directory (e.g. a README), skip it
+          return Promise.resolve(null);
+        }
+        // Otherwise, all directories must be integrations
+        const integ = new Integration(integPath);
+        await expect(integ.check()).resolves.toBe(true);
+      })
+    );
   });
 
   it('Should pass deep validation for all local integrations.', async () => {