Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple <p>s in a <blockquote> look bad. #4

Closed
hjiang opened this issue Dec 4, 2015 · 1 comment
Closed

Multiple <p>s in a <blockquote> look bad. #4

hjiang opened this issue Dec 4, 2015 · 1 comment
Assignees
@sparanoid
Labels
bug

Comments

@hjiang
Copy link
Contributor

hjiang commented Dec 4, 2015

The vertical quote indicator would break.

_ _1_byte
@sparanoid sparanoid added the bug label Dec 4, 2015
@sparanoid sparanoid self-assigned this Dec 4, 2015
@sparanoid
Copy link
Contributor

Currently you need special markup to make it look better:

<blockquote>
  <p>
    … these mean that in many fields the rule will be: Build it, and they will come.
  </p>

  <footer>
    <cite>Paul Graham</cite>
  </footer>
</blockquote>

I'll look for a better solution.

sparanoid added a commit that referenced this issue Dec 4, 2015
@sparanoid
feat(style): gapless border for blockquotes, fixes #4
ae9cdcf 
BREAKING CHANGE: Now paragraphs in a blockquote will get a single gapless border on the left side, you don't need special markup to achieve this now:

```markdown
> … these mean that in many fields the rule will be: Build it, and they will come.
>
> Paul Graham
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparanoid sparanoid

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjiang @sparanoid