Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the deprecated module with new module #528

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Update the deprecated module with new module #528

merged 1 commit into from
Nov 20, 2019

Conversation

chenw23
Copy link
Contributor

@chenw23 chenw23 commented Jul 19, 2019

The node-uuid module is deprecated and should not be used any more. Change this dependency to uuid module is appropriate.

The node-uuid module is deprecated and should not be used any more. Change this dependency to uuid module is appropriate.
Copy link
Collaborator

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need a change in the code using the module?

@chenw23
Copy link
Contributor Author

chenw23 commented Jul 27, 2019

No. Since the uuid module has the backward compatibility ability, no other change is needed.
Thanks for your review.

@squaremo squaremo merged commit cd616b5 into amqp-node:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants