Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency on github.com/go-acme/lego to v3.2.0 to get rid of indirect dependency on a now-unknown code commit #380

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

gabbifish
Copy link
Contributor

This PR bumps github.com/go-acme/lego to v3.2.0 to fix the indirect dependency on a now-unavailable revision:

go: finding github.com/labbsr0x/goh v0.0.0-20190417202808-8b16b4848295
go: github.com/labbsr0x/[email protected]: unknown revision 8b16b4848295

cc @twifkak

…direct dependency on a now-unknown code commit
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gabbifish
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@twifkak twifkak self-requested a review December 19, 2019 20:07
@twifkak
Copy link
Member

twifkak commented Dec 19, 2019

I have more to learn about go modules. Why is the original one failing? I see that commit hash 8b16b4848295 still exists, but I don't know if that means the go version v0.0.0-20190417202808-8b16b4848295 still does.

When I ran go get -v -x github.com/labbsr0x/[email protected] from a different go package, I got these errors:

# get https://proxy.golang.org/github.com/@v/v0.0.0-20190417202808-8b16b4848295.info: 410 Gone (1.479s)
# get https://proxy.golang.org/github.com/labbsr0x/@v/v0.0.0-20190417202808-8b16b4848295.info: 410 Gone (1.623s)

And those URLs turn up even weirder errors:

not found: [email protected]: unrecognized import path "github.com" (parse https://github.com/?go-get=1: no go-import meta tags ())
not found: github.com/[email protected]: invalid github.com/ import path "github.com/labbsr0x"

I'd thought it might have to do with the v0.0.0 label, but it seems that's some sort of sentinel "don't look for a tag" label, given that e.g. github.com/golang/snappy is getting along fine with a v0.0.0 label even though it doesn't have such a tag.

Anyway, understanding all that may be a problem for another day.

@twifkak twifkak merged commit 8673537 into ampproject:master Dec 19, 2019
@gabbifish
Copy link
Contributor Author

@twifkak this also really confuses me. If this were a direct dependency, I would have go get-ted the missing dependency at that exact hash, but since this is an indirect dependency, I can't really do that, I think.

I fumbled around trying to find a satisfactory answer for a bit, but so far I haven't found one...

@gabbifish gabbifish deleted the master branch December 19, 2019 20:40
@twifkak
Copy link
Member

twifkak commented Dec 19, 2019

Oh, BTW, thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants