Limit signature duration based on max_age_secs. #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregable
approved these changes
Sep 17, 2019
packager/signer/signer.go
Outdated
| @@ -477,11 +477,17 @@ func (this *Signer) serveSignedExchange(resp http.ResponseWriter, fetchResp *htt | |||
| if err != nil { | |||
| util.NewHTTPError(http.StatusInternalServerError, "Error building validity href: ", err).LogAndRespond(resp) | |||
| } | |||
| // Expires - Date must be <= 604800 seconds, per | |||
| // https://tools.ietf.org/html/draft-yasskin-httpbis-origin-signed-exchanges-impl-00#section-3.5. | |||
| duration := 7*24*time.Hour | |||
There was a problem hiding this comment.
suggest spaces around * for readability.
There was a problem hiding this comment.
Okay, ran go fmt on these two files, which fixed this.
packager/signer/signer.go
Outdated
| // Expires - Date must be <= 604800 seconds, per | ||
| // https://tools.ietf.org/html/draft-yasskin-httpbis-origin-signed-exchanges-impl-00#section-3.5. | ||
| duration := 7*24*time.Hour | ||
| println("max-age=", metadata.MaxAgeSecs) |
This uses the new metadata field returned from the transformer library, which is based on the presence of any inline amp-scripts.
twifkak
force-pushed
the
limit_duration
branch
from
75cb14d to
f5a144e
Compare
banaag
pushed a commit
to banaag/amppackager
that referenced
this pull request
Oct 23, 2019
This uses the new metadata field returned from the transformer library, which is based on the presence of any inline amp-scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new metadata field returned from the transformer library,
which is based on the presence of any inline amp-scripts.
@Gregable Note for review to ignore the first commit; it's merely the "diffbase" of #347.
cc @choumx