Go module conversion #346
Merged
Go module conversion #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banaag
force-pushed
the
go-module-conversion
branch
3 times, most recently
from
2e9d7a1 to
aa58cb7
Compare
banaag
force-pushed
the
go-module-conversion
branch
from
aa58cb7 to
e1f7b92
Compare
twifkak
requested changes
Sep 16, 2019
twifkak
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Thanks! After merging, please update https://github.com/ampproject/amppackager/wiki/Contributing#new-dependencies.
twifkak
added a commit
to twifkak/amppackager
that referenced
this pull request
Dec 5, 2019
where available. This reflects the change from dep to go1.11 modules in 83729a6 (ampproject#346).
twifkak
added a commit
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go dep to go-module conversion. Addresses #270