Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync from Google #341

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Conversation

honeybadgerdontcare
Copy link
Collaborator

This is an automatically generated pull request.

@twifkak
Copy link
Member

twifkak commented Sep 4, 2019

Looks like transformer/transformers/stripscriptcomments_test.go has a build failure; @amaltas can you fix Google-side so we can sync both CLs over?

@twifkak
Copy link
Member

twifkak commented Sep 6, 2019

@honeybadgerdontcare -- @amaltas fixed it in cl/267655188 -- you can try a sync again

Examples:
<script><!-- Hello --></script> == <script></script>

<script><!--[if IE]>var ie = true;<![endif]--></script> == <script></script>

PiperOrigin-RevId: 263786190
@honeybadgerdontcare honeybadgerdontcare force-pushed the DF79C833DEB28C2BD96ACEC0020A767D branch from 0cb645c to 514f73a Compare September 6, 2019 21:14
@honeybadgerdontcare honeybadgerdontcare requested review from Gregable and twifkak and removed request for twifkak September 6, 2019 21:30
@honeybadgerdontcare honeybadgerdontcare merged commit cad24b8 into master Sep 6, 2019
@honeybadgerdontcare honeybadgerdontcare deleted the DF79C833DEB28C2BD96ACEC0020A767D branch September 6, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants