Packager config mods #338
Packager config mods #338
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Remember to squash-and-merge per https://github.com/ampproject/amppackager/wiki/Contributing#what-merge-type.
packager/util/config.go
Outdated
| @@ -28,9 +28,13 @@ type Config struct { | |||
| Port int | |||
| CertFile string // This must be the full certificate chain. | |||
| KeyFile string // Just for the first cert, obviously. | |||
|
|
|||
| // NewCertFile will be read/write. CertFile and NewCertFile will be set when both | |||
There was a problem hiding this comment.
How about for the first sentence, "When set, both CertFile and NewCertFile will be read/write." (Though, as you're probably aware, the user-facing documentation is in amppkg.example.toml.)
Changes to amppackager toml file to accommodate ACME config changes.
Addresses #93