amppkg_dl_sxg: add -cert_url_path to override cert-url #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twifkak
reviewed
Jul 12, 2019
cmd/amppkg_dl_sxg/main.go
Outdated
| @@ -17,6 +19,7 @@ import ( | |||
|
|
|||
| var flagOutSXG = flag.String("out_sxg", "test.sxg", "Path to where the signed-exchange should be saved.") | |||
| var flagOutCert = flag.String("out_cert", "test.cert", "Path to where the cert-chain+cbor should be saved.") | |||
| var flagCertURL = flag.String("cert_url_path", "", "Override scheme, hostname and path in cert-url.") | |||
There was a problem hiding this comment.
Rename to cert_url_base. (Maybe s/path/parent path/ in the flag description?)
cmd/amppkg_dl_sxg/main.go
Outdated
| if err != nil { | ||
| log.Fatalf("%+v", err) | ||
| } | ||
| fURL, err := url.Parse(*flagCertURL) |
There was a problem hiding this comment.
Maybe move this url.Parse call inside the if *flagCertURL?
cmd/amppkg_dl_sxg/main.go
Outdated
| log.Fatalf("%+v", err) | ||
| } | ||
| if *flagCertURL != "" { | ||
| cURL.Scheme = fURL.Scheme |
There was a problem hiding this comment.
How about something like:
certHash := path.Base(cURL.Path)
cURL = fURL
cURL.Path = path.Join(cURL.Path, certHash)That way, the user can provide a user:pass@ or ?query too. (Admittedly, rare cases.)
During renewing of SXG cert in cluster servers, the new cert cannot be obtained in requesting cert-url from the cluster. `-cert_url_base` option enables us to overriding scheme, hostname and parent path of cert-url so that we can obtain the newer cert by specifying a server. In the server, we can get a new cert and confirm its cert renewal by using localhost such as `amppkg_dl_sxg -cert_url_base http://localhost:8080/amppkg/cert/ http://localhost:8080/priv/doc?...`
|
Thanks for your review. Fixes were done according to your comments. |
twifkak
approved these changes
Jul 15, 2019
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During renewing of SXG cert in cluster servers, the new cert cannot
be obtained in requesting cert-url from the cluster.
-cert_url_pathoption enables us to overriding scheme, hostname and path of cert-url
so that we can obtain the newer cert by specifying a server.
In the server, we can get a new cert and confirm its cert renewal by
using localhost such as
amppkg_dl_sxg -cert_url_path http://localhost:8080/amppkg/cert/ http://localhost:8080/priv/doc?...