Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amp analytics 3p vendors #9661

Closed
wants to merge 52 commits into from
Closed

Amp analytics 3p vendors #9661

wants to merge 52 commits into from

Commits on Jun 27, 2017

  1. Transfer files from old 3p_analytics to new fresh branch because it h… 

    …ad gotten very crufty
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    a4ea69b View commit details
    Browse the repository at this point in the history

  2. Now using iframe-messaging-client

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    dabbd98 View commit details
    Browse the repository at this point in the history

  3. Implements message throttling

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    2a4cd8f View commit details
    Browse the repository at this point in the history

  4. Wires up xframe response

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    cbead9f View commit details
    Browse the repository at this point in the history

  5. Fixes issues with multple ads

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    e919e86 View commit details
    Browse the repository at this point in the history

  6. Fixes extraData association with proper amp-analytics tag

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    7b5ba9d View commit details
    Browse the repository at this point in the history

  7. Fixes presubmits

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    d44fd58 View commit details
    Browse the repository at this point in the history

  8. Fixes whitespace only

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    7856841 View commit details
    Browse the repository at this point in the history

  9. Fixes linter issues, mostly whitespace

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    99bea30 View commit details
    Browse the repository at this point in the history

  10. Fixes a comment. Also makes doneWithCrossDomainIframe() become a stat… 

    …ic method.
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    cd5daac View commit details
    Browse the repository at this point in the history

  11. Fixes unit tests

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    ff6952e View commit details
    Browse the repository at this point in the history

  12. Review feedback low-hanging fruit

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    e3f7e79 View commit details
    Browse the repository at this point in the history

  13. Makes event names more explicit to 3p use case

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    eb9c356 View commit details
    Browse the repository at this point in the history

  14. Moves helper JS to 3p, compiles in imported resources, so helper JS n… 

    …ow uses these (mainly iframe-messaging-client)
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    a403e37 View commit details
    Browse the repository at this point in the history

  15. Fixes message ordering so that extraData is always enqueued first. Ex… 

    …tra data and event messages now live in a common queue. Therefore ampanalytics-lib now iterates through the list of received messages to sort out the two types, so the customer-implemented code now receives an event, not an array of events.
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    6be6c26 View commit details
    Browse the repository at this point in the history

  16. Extracts calls to timerFor(window) to a static class member, which no… 

    …w uses AMP.win
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    9a2900f View commit details
    Browse the repository at this point in the history

  17. Parameterizes click URL substitution. Stops using frame load promise … 

    …(in progress / checkpoint). Makes requestIdleCallback polyfill easier to test. Uses enclosed object to store responses.
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    d8e1517 View commit details
    Browse the repository at this point in the history

  18. Fixes timer logic which can result in lost messages upon delayed fetch

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    06b11ed View commit details
    Browse the repository at this point in the history

  19. Merge of gulpfile.js

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    6bc9776 View commit details
    Browse the repository at this point in the history

  20. Fix linter issues. Refactor object that encloses xframe responses

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    e8c7f1f View commit details
    Browse the repository at this point in the history

  21. 1:1 checkpoint

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    7ce3793 View commit details
    Browse the repository at this point in the history

  22. Makes response be an object, not string. Includes real absolute URL f… 

    …or when not running locally.
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    0c8b3a2 View commit details
    Browse the repository at this point in the history

  23. Makes iframeMessagingClient now accept a newly-created iframe, and up… 

    …on getting the first message from that iframe, sets host window to that iframe's contentWindow. So, now uses iframeMessagingClient exclusively in transport.js. Also adds some comments, etc.
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    08706f8 View commit details
    Browse the repository at this point in the history

  24. Moves message type strings to an enum. Fixes closure typing issues

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    d44ca1b View commit details
    Browse the repository at this point in the history

  25. Fix closure typing issues

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    8b6cec8 View commit details
    Browse the repository at this point in the history

  26. Changes closure typing

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    beb78eb View commit details
    Browse the repository at this point in the history

  27. Removes gulpfile change that breaks type checking

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    af36850 View commit details
    Browse the repository at this point in the history

  28. Adds file that enum and response container were extracted to

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    faad371 View commit details
    Browse the repository at this point in the history

  29. Changes the flow to provide one AmpAnalytics3pCreativeMessageRouter p… 

    …er creative, and onNewAmpAnalyticsInstance will be called for each
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    30da904 View commit details
    Browse the repository at this point in the history

  30. Fixes closure typing

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    21fb523 View commit details
    Browse the repository at this point in the history

  31. Replaces 2 lines accidentally deleted during rebase

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    6a53ab6 View commit details
    Browse the repository at this point in the history

  32. Addresses review feedback, mostly minor

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    cc245fa View commit details
    Browse the repository at this point in the history

  33. Refactors message queueing from Transport into new class. Adds extern… 

    … typedefs. Fixes error in which asserts cause error due to no ampdoc
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    b8bd741 View commit details
    Browse the repository at this point in the history

  34. Addresses review feedback re: minor code organization issues and logi… 

    …c flaw when sentinel is missing
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    b7d8665 View commit details
    Browse the repository at this point in the history

  35. Addresses PR feedback, mostly typing, and format of messages

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    c25c199 View commit details
    Browse the repository at this point in the history

  36. Replaces custom throttling code with src/utils/rate-limit

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    59170c8 View commit details
    Browse the repository at this point in the history

  37. Changes format of postMessage messages

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    896e9fc View commit details
    Browse the repository at this point in the history

  38. Addresses review feedback, mostly minor code style stuff

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    10c6cd9 View commit details
    Browse the repository at this point in the history

  39. Removes frame-side message queueing which was necessary under old mes… 

    …sage format, but new message format resulted in this being over-engineered
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    14e9939 View commit details
    Browse the repository at this point in the history

  40. Addresses review feedback

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    be9c95c View commit details
    Browse the repository at this point in the history

  41. Updates linter compliance

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    036e2d0 View commit details
    Browse the repository at this point in the history

  42. Implements changes from self-review, mostly nits

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    7d3074b View commit details
    Browse the repository at this point in the history

  43. Updates response handling to new data format

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    36918a4 View commit details
    Browse the repository at this point in the history

  44. Addresses PR feedback, mostly nits

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    3aeb8de View commit details
    Browse the repository at this point in the history

  45. Puts anchor click listener binding into AmpDoc

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    591e18c View commit details
    Browse the repository at this point in the history

  46. Fixes Travis issue that check-types is not catching locally

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    c446a5e View commit details
    Browse the repository at this point in the history

  47. Removes throw statement from abstract method body, since the ensueing… 

    … warning makes Travis fail
    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    3c71898 View commit details
    Browse the repository at this point in the history

  48. Trivial comment change, to force Percy to run again

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    dd4034b View commit details
    Browse the repository at this point in the history

  49. Adds unit tests

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    f80268d View commit details
    Browse the repository at this point in the history

  50. Makes typing of frame name more deliberate

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    e0b9f71 View commit details
    Browse the repository at this point in the history

  51. Just modifies comment, to force CI to re-run

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    c84129a View commit details
    Browse the repository at this point in the history

  52. Fixes typing of frame name, for real this time

    @jonkeller
    jonkeller committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    94cf287 View commit details
    Browse the repository at this point in the history