Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move percy keys from encrypted .travis.yml entries to travis config #9314

Merged
merged 2 commits into from
May 17, 2017
Merged

Move percy keys from encrypted .travis.yml entries to travis config #9314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
749bd32
Move percy keys from encrypted travis.yml entries to travis config
rsimha May 12, 2017
87aaf15
Token logging
rsimha May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ branches:
env:
global:
- NPM_CONFIG_PROGRESS="false"
- secure: nvLqQdU2CGwvsQ3E1M/6HgBJAfmSzd90bDYQ1vkAkwGj+VOVQauqj7RDJACJS2XysJjzIvzNUOtKFvTSzThye167sKAZnQMmj9U8ATdlJfv5xq88QkkoCuJIOPtVnOWS8gBrDAy9d+Xwi22ZcE5kAAov1gNDmnX6YcPwW8y09vD+Jb1WkxofwTR5U3dP7pxVNRwgXY12g2lmbj+TZy5RHvjs1/ESSVtt/5Wq+Ubv9O6KAVPrh/VdVTYyvgynvwzz5jG3qe7981W8rUNIt+ihzdxJMSaoQkiBs5UM3qi8ibqKI2KHdDmGQg+vc/c5mjCCd9FAz7lF+fJJQ3YThTLmIN3u7Hil+o92OaAt2knwtZ3HRv/jbVQfnU0L9hqHw/kBYE37O4x4/ToJyR3EgbvFXqgiVph0eDUnsmi8PZc5FUiwb8r85thQmfUB+urkOXbnOyHQ9B74T+UjAvlaqLdQ53/9UTzgvLNm2z6RU65G9QYJVMSzj82K2rZ9AyVwjZMp/iuQDoUcUsuMhKDh2genHnxRtQa/TbLQM05oYHRqFa9oT3Q7C7QSSL8mmi/QMfGlTfxhM49CZsbcU2qbMCMCL7ZGWaSiXiEy7XICOzJnOiKFowDK5ihAZaQpRNquMwUSIMnnqrFgfWDbQSUmkOAwSm+2u2+SsXhT+WQfraRfSSI=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were moved elsewhere right? Is it okay that these were publicly visible on github?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is travis' mechanism to safely do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are now part of the travis config, and are in a mode where they are not printed within logs. This is exactly how we store our sauce tokens.

- secure: Yy/T45bp95od5bugtZFnr8e/YSc+8aPaiPQiI+Ms7T6TF/7NsjqwLHCgpd6TlSnkmuusHuI1N6foEHl9tu4XFjDdIl7qZvGLpNodSo5bFnKz8fVxHiZeCn6x6EMIx2QOw7Matrp6P7E2wV9DgQsmMhQQ2BNPu7XyJx8K6DbE654IFsHO9N3y9qO4TiZ2hfypGM7XCGZsLGo+amS/XbfJZDCupK3GTmWoA4M/liUSdRjM+9ienXC76bDw2Mf06WJ9RpsdYI4nVFRe1kkEUzu/1DJSh5oqkxtbYph4KHjh/2cTmzYGG03rPGxE07ndZKcBhdaiYuECTqps4zQ8ST4DouwxPecwbMZ0lpzUFYtSrZOC+iplxiaOWeombNsLRgswy4L+mOpqyQjsWQ8vLUqhSxyMY8BAXSJVOeBeMOLvYfC2UVscqcQsX2MwQA/izDWMFZrpqGBCPIieoWBatAb2QzCHGtL3K5cvnwSK6O+LC+nZJ8kR3Yl6zSyfKnnx46tyzqkNRQ11gvLCrnBOtjGtOt48Z3GmXb0KONCF8nu2Wb2ZbgN9Mi2KyI3+3gDRANzOqfjhByLyvuwCI8fWnogJIy5ZPVpZQC85GTUZBOMZMpQiVtcfv50qByRvtnn3aavE1KtcEFwj9Gaen/A+yO8EMnBJhc3SNf1ggJ2B18O6CBQ=
cache:
yarn: true
directories:
Expand Down
4 changes: 3 additions & 1 deletion build-system/tasks/visual-diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ function extractPercyKeys() {
'Error: PERCY_TOKEN doesn\'t look like a valid Percy API key'));
process.exit(1);
}
util.log('Percy token: ', util.colors.magenta('<redacted>'));
// Note: The secret percy token only gets printed during local use. Travis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who will be able to see the token?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only engineers who want to do a local visual diff run, who already have access to the tokens. Those who access the public travis logs will not see the token in the logs.

// will hide it in publicly accessible logs.
util.log('Percy token: ', util.colors.magenta(percyToken));
return {
percyProject: percyProject,
percyToken: percyToken,
Expand Down