Duplicate errors that are un-writable #9046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
force-pushed
the
unwritable-errors
branch
from
28c256b
to
09ddee4
Compare
jridgewell
force-pushed
the
unwritable-errors
branch
from
09ddee4
to
a6a5e36
Compare
dvoytenko
reviewed
May 2, 2017
| e[prop] = error[prop]; | ||
| } | ||
| // Ensure these are copied. | ||
| e.stack = error.stack; |
There was a problem hiding this comment.
I'm not 100% sure that stack is an enumerable property in all browsers, so it seemed like a good defense.
Or, are you asking about overriding the stack? In that case, yup, it's a thing. It's used a lot to clean stack traces, avoiding "internal" frames.
dvoytenko
approved these changes
May 2, 2017
jridgewell
force-pushed
the
unwritable-errors
branch
from
9a8f07c
to
f54235a
Compare
Certain errors (`DOMException`s, really) have un-writable error messages. This mucks with our code, since we rewrite it to signal user errors, give context, etc. If an error's message isn't writable, duplicate the error with one that is.
jridgewell
force-pushed
the
unwritable-errors
branch
from
f54235a
to
2de9157
Compare
|
Do I need to cherry pick this to 1% canary (to be promoted to prod) and opt in canary (to be deployed)? |
|
Nah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain errors (
DOMExceptions, really) have un-writable errormessages. This mucks with our code, since we rewrite it to signal user
errors, give context, etc.
If an error's message isn't writable, duplicate the error with one that
is.
Fixes #8917.