Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test on old chrome #8968

Merged
merged 4 commits into from
Apr 27, 2017
Merged

Skip test on old chrome #8968

merged 4 commits into from
Apr 27, 2017

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Apr 26, 2017

quick fix for #8965

lannka
lannka approved these changes Apr 26, 2017
View reviewed changes
Copy link
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add TODO in code, pointing to the issue? We should revisit in next sprint.

@jridgewell
Copy link
Contributor

I've got a few better fixes coming.

@jridgewell jridgewell mentioned this pull request Apr 26, 2017
Merged
@jridgewell
Copy link
Contributor

#8969

@zhouyx
Copy link
Contributor Author

zhouyx commented Apr 26, 2017

That's good! In that case I'll just leave the skipOldChrome() function then. (wanted to have that for long)

@lannka
Copy link
Contributor

lannka commented Apr 27, 2017

Seems the #8969 does not solve the issue on travis. We might still need this PR in to unblock release. @jridgewell

@zhouyx zhouyx merged commit c0be98e into ampproject:master Apr 27, 2017
@zhouyx zhouyx deleted the skip-old-chrome-test branch April 27, 2017 20:27
@zhouyx zhouyx mentioned this pull request Apr 27, 2017
Closed
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
@zhouyx @mrjoro
Skip test on old chrome (ampproject#8968)
8fda551
KenneyE pushed a commit to spotxchange/amphtml that referenced this pull request May 3, 2017
@zhouyx
Skip test on old chrome (ampproject#8968)
fab0060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhouyx @jridgewell @lannka @ampprojectbot