Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush out the AMP dev-mode spec documentation #766

Merged
merged 1 commit into from
Oct 27, 2015
Merged

Flush out the AMP dev-mode spec documentation #766

merged 1 commit into from
Oct 27, 2015

Conversation

Gregable
Copy link
Member

Flush out the AMP dev-mode spec documentation on methods for triggering development mode and the related warnings generated.

development mode and the related warnings generated.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Gregable
Copy link
Member Author

I signed it!

@dvoytenko dvoytenko added the LGTM label Oct 27, 2015
@dvoytenko dvoytenko self-assigned this Oct 27, 2015
@dvoytenko
Copy link
Contributor

@Gregable LGTM. Is it ready to be merged or are you still changing it?

@Gregable
Copy link
Member Author

Ready to be merged if you are OK with it.

@Gregable
Copy link
Member Author

@dvoytenko, I don't have the rights to actually merge this, fyi.

dvoytenko added a commit that referenced this pull request Oct 27, 2015
Flush out the AMP dev-mode spec documentation
@dvoytenko dvoytenko merged commit f4f94cb into ampproject:master Oct 27, 2015
@Gregable Gregable deleted the development-docs branch November 30, 2015 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants