-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change attributes to lower case #73
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Thanks for the PR! Would you mind signing the CLA. So, I made these uppercase because then you can just copy paste them from the twitter docs which I felt was kind of a win. You are absolutely right, though, that case isn't preserved which currently requires an ugly hack for the one property that actually has an uppercase char. So, I think this should go in :) |
Thanks I've signed the CLA. |
CLAs look good, thanks! |
change attributes to lower case
some of the twitter attributes are upper case. This isn't the usual way for HTML, normally everything is lower case.
We noticed because we use jsoup to generate parts of our pages which automatically changes things to lower case.
Actually if we put them in lower case it still seems to work, but we should make sure the docs match.