Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change attributes to lower case #73

Merged
merged 1 commit into from
Sep 11, 2015
Merged

change attributes to lower case #73

merged 1 commit into from
Sep 11, 2015

Conversation

johnduffell
Copy link
Contributor

some of the twitter attributes are upper case. This isn't the usual way for HTML, normally everything is lower case.

We noticed because we use jsoup to generate parts of our pages which automatically changes things to lower case.

Actually if we put them in lower case it still seems to work, but we should make sure the docs match.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@cramforce
Copy link
Member

Thanks for the PR! Would you mind signing the CLA.

So, I made these uppercase because then you can just copy paste them from the twitter docs which I felt was kind of a win. You are absolutely right, though, that case isn't preserved which currently requires an ugly hack for the one property that actually has an uppercase char.

So, I think this should go in :)

@johnduffell
Copy link
Contributor Author

Thanks I've signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

cramforce added a commit that referenced this pull request Sep 11, 2015
change attributes to lower case
@cramforce cramforce merged commit 89f2f78 into ampproject:master Sep 11, 2015
@johnduffell johnduffell deleted the patch-1 branch September 11, 2015 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants