Forbid direct style manipulation #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
approved these changes
Nov 3, 2016
camelburrito
approved these changes
Nov 3, 2016
They must go through `setStyle` or `setStyles`.
jridgewell
force-pushed
the
style-presubmit
branch
from
ea00f83
to
ca9bbf2
Compare
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Nov 15, 2016
* Forbid direct style manipulation They must go through `setStyle` or `setStyles`. * Lint * Types * Allow 3p to depend on style module * Test fixes
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Forbid direct style manipulation They must go through `setStyle` or `setStyles`. * Lint * Types * Allow 3p to depend on style module * Test fixes
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Forbid direct style manipulation They must go through `setStyle` or `setStyles`. * Lint * Types * Allow 3p to depend on style module * Test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They must go through
setStyleorsetStyles.Follow up to #6003.