Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Timer promises catch clause #5758

Merged
merged 2 commits into from
Oct 24, 2016
Merged

Remove Timer promises catch clause #5758

merged 2 commits into from
Oct 24, 2016

Conversation

jridgewell
Copy link
Contributor

Timer's promises can only fail because of being unable to schedule.

So timerKey is either:

  • -1, in which case the catch is unnecessary
  • Some timer id, whose promise will eventually resolve.

cramforce
cramforce approved these changes Oct 24, 2016
View reviewed changes
Copy link
Member

@cramforce cramforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% sure this LGTM

@jridgewell
Remove Timer promises catch clause
73c66b4 
Timer's promises can only fail because of being unable to schedule.
@jridgewell jridgewell mentioned this pull request Oct 24, 2016
Closed
@jridgewell jridgewell merged commit 151a343 into ampproject:master Oct 24, 2016
@erwinmombay erwinmombay mentioned this pull request Oct 24, 2016
Closed
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
@jridgewell
Remove Timer promises catch clause (ampproject#5758)
ce9c721 
* Remove Timer promises catch clause

Timer's promises can only fail because of being unable to schedule.

* Temp fix amp-form tests

Re: ampproject#5775
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
@jridgewell
Remove Timer promises catch clause (ampproject#5758)
cba90f6 
* Remove Timer promises catch clause

Timer's promises can only fail because of being unable to schedule.

* Temp fix amp-form tests

Re: ampproject#5775
This was referenced Jul 16, 2020
Closed
Closed
This was referenced Dec 30, 2020
Closed
Closed
Closed
Closed
@ampprojectbot ampprojectbot mentioned this pull request Mar 4, 2021
Open
@ampprojectbot ampprojectbot mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cramforce cramforce cramforce approved these changes

Assignees

@cramforce cramforce

Labels
P3: When Possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jridgewell @cramforce