Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Update linting devDependencies #40105

Merged
merged 2 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-system/common/logging.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const {isCiBuild} = require('./ci');
* Used by tests to wrap progress dots. Attempts to match the terminal width
* during local development and defaults to 150 if it couldn't be determined.
*/
const dotWrappingWidth = isCiBuild() ? 150 : process.stdout.columns ?? 150;
const dotWrappingWidth = isCiBuild() ? 150 : (process.stdout.columns ?? 150);

/**
* Used by CI job scripts to print a prefix before top-level logging lines.
Expand Down
2 changes: 1 addition & 1 deletion build-system/server/new-server/transforms/transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import transformModules from './modules/modules-transform';
const argv = minimist(process.argv.slice(2));
const FOR_TESTING = argv._.includes('integration');
// Use 9876 if running integration tests as this is the KARMA_SERVER_PORT
const PORT = FOR_TESTING ? 9876 : argv.port ?? 8000;
const PORT = FOR_TESTING ? 9876 : (argv.port ?? 8000);
const ESM = !!argv.esm;

const defaultTransformConfig = {
Expand Down
2 changes: 1 addition & 1 deletion build-system/tasks/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ async function esbuildCompile(srcDir, srcFilename, destDir, options) {
const entryPoint = path.join(srcDir, srcFilename);
const filename = options.minify
? options.minifiedName
: options.toName ?? srcFilename;
: (options.toName ?? srcFilename);
// This guards against someone passing `minify: true` but no `minifiedName`.
if (!filename) {
throw new Error('No minifiedName provided for ' + srcFilename);
Expand Down
Loading
Loading