Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ New feature (I2I: Sending data-json to premiumads API for amp-auto-ads #40041 ) #40042

Merged
merged 8 commits into from
Aug 20, 2024
Merged

✨ New feature (I2I: Sending data-json to premiumads API for amp-auto-ads #40041 ) #40042

merged 8 commits into from
Aug 20, 2024

Conversation

rochapablo
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Jun 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rochapablo rochapablo closed this Jun 5, 2024
@rochapablo rochapablo reopened this Jun 5, 2024
@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

1 similar comment
@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

@rochapablo rochapablo marked this pull request as draft June 20, 2024 19:04
@rochapablo rochapablo marked this pull request as ready for review June 20, 2024 19:20
@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

4 similar comments
@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

@rochapablo
Copy link
Contributor Author

/cc @ampproject/wg-approvers

@rochapablo rochapablo requested a review from powerivq August 5, 2024 17:44
@rochapablo rochapablo requested a review from powerivq August 9, 2024 16:50
@powerivq
Copy link
Contributor

powerivq commented Aug 9, 2024

@rochapablo You need to do a rebase. The build is still failing.

@rochapablo
Copy link
Contributor Author

@rochapablo You need to do a rebase. The build is still failing.

Done, but unfortunately there are testes failing on main branch.

@rochapablo
Copy link
Contributor Author

@rochapablo You need to do a rebase. The build is still failing.

@powerivq can you review again please?

@powerivq powerivq merged commit 51c6913 into ampproject:main Aug 20, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rochapablo @CLAassistant @powerivq @ampprojectbot