Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗🐛 Fix incorrect condition for headless mode in visual-diff task #39986

Conversation

danielrozenberg
Copy link
Member

headless: !!argv.dev means that visual diffs run in headless mode when we pass --dev, and with full UI when there's no --dev in the args list. This is the exact opposite of what we want 😅

@danielrozenberg danielrozenberg enabled auto-merge (squash) May 6, 2024 15:01
@danielrozenberg danielrozenberg merged commit ac8532e into ampproject:main May 6, 2024
51 checks passed
@danielrozenberg danielrozenberg deleted the visual-diff-incorrect-headless branch May 6, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants