✨[amp-ad smartadserver] Include consent data in iframe name #39965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @smart-adserver! These files were changed: |
powerivq
approved these changes
Apr 17, 2024
|
Hello @powerivq, thank you for the review and approve. I noticed that some test is failing and I'm not sure why, could you please take a look on it and give me some hint? All ut from our extensions are passing. Thanks in advance for your time. |
|
@eszponder I would suggest rebasing against the latest main branch. |
|
@eszponder I am wondering what we are doing here? The PR is now empty. |
ampprojectbot
temporarily deployed
to
release_tagger
GitHub Actions
Inactive
Sadr 5675 - include consent for GPT
|
Hello @powerivq I was doing rebase as you suggested and I had some conflicts so I removed my commits for a while. Now the PR is updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.