Fix Commander Program deprecated default program import with named import #39932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per migration docs of Commander v12, use the named import instead of the deprecated default import. https://github.com/tj/commander.js/tree/v12.0.0 https://github.com/tj/commander.js/blob/v12.0.0/docs/deprecated.md#default-import-of-global-command-object
|
|
|
Hey @ampproject/wg-caching! These files were changed: |
This was referenced Mar 29, 2024
powerivq
approved these changes
Apr 1, 2024
|
@erwinmombay for approval |
erwinmombay
approved these changes
Apr 1, 2024
eos87
added a commit
to liveblog/liveblog
that referenced
this pull request
Apr 2, 2024
The commander dependency on `amp-validator` was bumped to the version 12.0.0 which is not compatible with out current version of Node.js ampproject/amphtml#39932 LBSD-2733
TribooAnalytics
pushed a commit
to TribooAnalytics/amphtml
that referenced
this pull request
Apr 3, 2024
…9932) Per migration docs of Commander v12, use the named import instead of the deprecated default import. https://github.com/tj/commander.js/tree/v12.0.0 https://github.com/tj/commander.js/blob/v12.0.0/docs/deprecated.md#default-import-of-global-command-object
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
…9932) Per migration docs of Commander v12, use the named import instead of the deprecated default import. https://github.com/tj/commander.js/tree/v12.0.0 https://github.com/tj/commander.js/blob/v12.0.0/docs/deprecated.md#default-import-of-global-command-object
eos87
added a commit
to liveblog/liveblog
that referenced
this pull request
Apr 25, 2024
The commander dependency on `amp-validator` was bumped to the version 12.0.0 which is not compatible with out current version of Node.js ampproject/amphtml#39932 LBSD-2733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
The
amphtml-validatornpm package is currently broken in 1.0.36 if one tries to use the command:npx amphtml-validator index.html /workspaces/website/node_modules/amphtml-validator/index.js:378 .usage( ^ TypeError: program.usage is not a function at main (/workspaces/website/node_modules/amphtml-validator/index.js:378:8) at Object.<anonymous> (/workspaces/website/node_modules/amphtml-validator/cli.js:7:1) at Module._compile (node:internal/modules/cjs/loader:1369:14) at Module._extensions..js (node:internal/modules/cjs/loader:1427:10) at Module.load (node:internal/modules/cjs/loader:1206:32) at Module._load (node:internal/modules/cjs/loader:1022:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12) at node:internal/main/run_main_module:28:49This is because the most recent release of
amphtml-validatorintroduces a breaking change with thev12.0.0Commander dependency.Per migration docs of Commander v12, use the named import instead of the deprecated default import.
https://github.com/tj/commander.js/tree/v12.0.0
https://github.com/tj/commander.js/blob/v12.0.0/docs/deprecated.md#default-import-of-global-command-object
Making this change outlined in their migration note (and locally), it fixes my
amphtml-validatorexecution of files.Emojis for categorizing pull requests (copy-paste emoji into description):
🐛 Bug fix