Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Check for consent before writing ADCID. #39880

Merged
merged 6 commits into from
Apr 9, 2024

Lint fixes

98e3855
Select commit
Loading
Failed to load commit list.
Merged

🐛Check for consent before writing ADCID. #39880

Lint fixes
98e3855
Select commit
Loading
Failed to load commit list.
AMP bundle-size / ampproject/bundle-size succeeded Apr 9, 2024 in 4m 46s

No approval necessary

This pull request does not change any brotli bundle sizes by a significant amount, so no special approval is necessary.

Commit details

Head commit: 98e3855
Base commit: c8fe081
Code changes: b3936a9

Auto-approved bundle size changes

  • dist/v0/amp-ad-network-nws-impl-0.1.mjs: Δ -0.02KB
  • dist/v0/amp-ad-network-dianomi-impl-0.1.mjs: Δ +0.05KB
  • dist/v0/amp-ad-network-mgid-impl-0.1.mjs: Δ +0.04KB
  • dist/v0/amp-ad-network-adzerk-impl-0.1.mjs: Δ +0.07KB
  • dist/v0/amp-ad-network-fake-impl-0.1.mjs: Δ +0.05KB
  • dist/v0/amp-ad-network-nws-impl-0.1.js: Δ +0.08KB
  • dist/v0/amp-ad-network-dianomi-impl-0.1.js: Δ +0.09KB
  • dist/v0/amp-ad-network-adzerk-impl-0.1.js: Δ +0.05KB
  • dist/v0/amp-ad-network-mgid-impl-0.1.js: Δ +0.02KB
  • dist/v0/amp-ad-network-smartadserver-impl-0.1.mjs: Δ +0.05KB
  • dist/v0/amp-ad-network-fake-impl-0.1.js: Δ +0.02KB
  • dist/v0/amp-ad-network-valueimpression-impl-0.1.mjs: Δ +0.04KB
  • dist/v0/amp-ad-network-smartadserver-impl-0.1.js: Δ +0.10KB
  • dist/v0/amp-ad-network-adsense-impl-0.1.mjs: Δ +0.14KB
  • dist/v0/amp-ad-network-valueimpression-impl-0.1.js: Δ +0.10KB
  • dist/v0/amp-ad-network-doubleclick-impl-0.1.mjs: Δ +0.02KB
  • dist/v0/amp-ad-network-adsense-impl-0.1.js: Δ +0.03KB
  • dist/v0/amp-ad-network-doubleclick-impl-0.1.js: Δ +0.08KB
View more details on AMP bundle-size