🏗🐛 Install Chrome in CircleCI Module 3p Build (Test) job, for empty visual-diff edge-case
#39878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
module-chrome
branch
from
6897570 to
f0af919
Compare
…sual-diff edge-case
danielrozenberg
force-pushed
the
module-chrome
branch
from
f0af919 to
6c68ce8
Compare
erwinmombay
approved these changes
Mar 6, 2024
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
… visual-diff edge-case (ampproject#39878)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of where this fails as of now: https://app.circleci.com/pipelines/github/ampproject/amphtml/30407/workflows/7b9680ee-501d-4f56-a871-7682b9781fd3/jobs/653480
Example of how this PR fixes this: https://app.circleci.com/pipelines/github/ampproject/amphtml/30408/workflows/7b455776-e6aa-4cd4-af41-dc13937836f0/jobs/653511