Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❄️ Flaky tests #39877

Merged
merged 3 commits into from
Mar 6, 2024
Merged

❄️ Flaky tests #39877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44d8e89
Attempt at deflaking amp-consent tests
danielrozenberg Mar 6, 2024
eaa8765
Disable flaky test
danielrozenberg Mar 6, 2024
5b0bd6e
Disable flaky test
danielrozenberg Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extensions/amp-analytics/0.1/test/test-events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,8 @@ describes.realWin('Events', {amp: 1}, (env) => {
});
});

it(
// TODO(#39879): fix this flaky test.
it.skip(
'timers started and stopped by the same event on the same target' +
' do not have race condition problems',
() => {
Expand Down
3 changes: 2 additions & 1 deletion extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ describes.endtoend(
await expect(slidesRects[0].width).to.equal(pageWidth);
});

it('should layout the two adjacent slides', async function () {
// TODO(#24195): fix this flaky test.
it.skip('should layout the two adjacent slides', async function () {
const [firstSlideRect, secondSlideRect, lastSlideRect] = [
await controller.getElementRect(await getSlide(controller, 0)),
await controller.getElementRect(await getSlide(controller, 1)),
Expand Down
4 changes: 2 additions & 2 deletions extensions/amp-consent/0.1/test/test-amp-consent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {xhrServiceForTesting} from '#service/xhr-impl';

import {dev, user} from '#utils/log';

import {macroTask} from '#testing/helpers';
import {macroTask, sleep} from '#testing/helpers';

import {
registerServiceBuilder,
Expand Down Expand Up @@ -1161,7 +1161,7 @@ describes.realWin(

beforeEach(async () => {
ampConsent.buildCallback();
await macroTask();
await sleep(50);
managerSpy = env.sandbox.spy(
ampConsent.consentStateManager_,
'updateConsentInstancePurposes'
Expand Down
Loading