Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Nicer format for test names when reporting to CircleCI #39859

Merged

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Feb 26, 2024

This PR reduces the full name of tests to only be the text in the it('...') spec, and adds delimiters to different describes texts for the classname. Also removes empty strings in the middle (which happens as a side-effect of how we implemented some of the test runners)

Before After
image image
image image

@danielrozenberg danielrozenberg force-pushed the improve-test-result-name branch from 10027d4 to 0e76c80 Compare February 26, 2024 19:13
@danielrozenberg danielrozenberg marked this pull request as ready for review February 26, 2024 20:13
@danielrozenberg danielrozenberg force-pushed the improve-test-result-name branch from 0e76c80 to 4bf95bd Compare February 28, 2024 21:24
@danielrozenberg danielrozenberg merged commit 01b1240 into ampproject:main Feb 29, 2024
52 checks passed
@danielrozenberg danielrozenberg deleted the improve-test-result-name branch February 29, 2024 17:13
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants