🏗 Fix for recent changes to Chromedriver installation on CircleCI #39856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
circleci-chromedriver-fix
branch
3 times, most recently
from
afd2241 to
84c8c21
Compare
danielrozenberg
changed the title
circleci/browser-tools to v1.4.8
ychsieh
previously approved these changes
Feb 22, 2024
auto-merge was automatically disabled
February 22, 2024 16:55
Pull request was converted to draft
danielrozenberg
force-pushed
the
circleci-chromedriver-fix
branch
8 times, most recently
from
1b24c7c to
cea1deb
Compare
danielrozenberg
changed the title
circleci/browser-tools to v1.4.8
danielrozenberg
force-pushed
the
circleci-chromedriver-fix
branch
4 times, most recently
from
8acdb9d to
553f536
Compare
danielrozenberg
force-pushed
the
circleci-chromedriver-fix
branch
3 times, most recently
from
b4751a2 to
89ff197
Compare
danielrozenberg
force-pushed
the
circleci-chromedriver-fix
branch
2 times, most recently
from
f6a6041 to
bdba728
Compare
danielrozenberg
force-pushed
the
circleci-chromedriver-fix
branch
from
bdba728 to
a487954
Compare
danielrozenberg
dismissed
ychsieh’s stale review
Made big changes to this PR, probably should get this approved from scratch
erwinmombay
approved these changes
Feb 22, 2024
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
…pproject#39856) * Fix for newly broken Chromedriver issues * Use the Chrome version installed by CircleCI in `amp visual-diff` * Disable flaky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circleci/browser-toolsOrb to v1.4.8chromedriver_skip_download=true, since we're installing it with the Orb (and it currently fails for the same reason that the Orb's previous version failed - the download URL changed)amp visual-diff