feat: allow payment in amp-consent external ui #39855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcmrf
commented
Feb 22, 2024
| @@ -471,6 +473,7 @@ export class ConsentUI { | |||
| const iframe = this.parent_.ownerDocument.createElement('iframe'); | |||
| const sandbox = this.getSandboxAttribute_(promptUISrc); | |||
| iframe.setAttribute('sandbox', sandbox); | |||
| iframe.setAttribute('allow', IFRAME_ALLOWED_PERMISSIONS.join('; ')); | |||
There was a problem hiding this comment.
Not doing it via config as commented here #39745 (comment). Should I add any other permission?
erwinmombay
requested review from
erwinmombay and
powerivq
and removed request for
alanorozco
powerivq
approved these changes
Mar 13, 2024
|
@marcmrf Please rebase against the latest main branch. Once it passes the tests, I will be able to merge it. |
|
@powerivq done! 🙏 Thx for the review. |
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #39745. As described in the issue, new EU regulations demand the sites to offer a reject all option with the same visibility than the accept all one. However, they also open the door for asking for a retribution for accessing the content if user wants to reject cookies.
allow="payment"is required if the iframe want to make use of payment api.