-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Connatix dock UI fullscreen support #39834
🐛 Connatix dock UI fullscreen support #39834
Conversation
Hey @alanorozco! These files were changed:
|
/** @override */ | ||
fullscreenEnter() { | ||
/** @override */ | ||
fullscreenEnter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix lint issues.
amp lint --fix --local_files
should do the trick. (make sure you have committed all your changes first before running the command since it is destructive)
@cristisilav could you rebase against the latest main branch? That should fix the build issue. |
* Add Dock UI fullscreen button support * small fix * add break at end of switch statement * fix lint * update test
After some changes on our player's side, we were able to finally update the flow in the AMP component that was required for enabling full dock UI fullscreen button functionality.