Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable amp-img to be rendered inside amp-list in story page attachment #39806

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ychsieh
Copy link
Contributor

@ychsieh ychsieh commented Feb 7, 2024

For amp-list embedded in the amp-story-page-attachment, because the attachment is initially in nodisplay mode, the layoutCallback of all amp-img elements are not called at all, even after the attachment is opened and amp-list fetches results and inserted built amp-img(from templates) into DOM. Force call layoutCallback to render images.

Fix #39707 and #33241.

@ychsieh ychsieh requested a review from erwinmombay February 7, 2024 22:30
@ychsieh ychsieh self-assigned this Feb 7, 2024
@ychsieh ychsieh merged commit f49932e into ampproject:main Feb 13, 2024
42 of 43 checks passed
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp-story and image handling
3 participants