Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Story Preview] Allow amp-story-360 in preview mode #38229

Merged
merged 7 commits into from
Jun 8, 2022
Merged

✨ [Story Preview] Allow amp-story-360 in preview mode #38229

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ebfdbc3
Enable amp-story-360 and amp-story-captions in preview mode
coreymasanto May 23, 2022
7048b4a
Create skeleton code for AmpStory360's previewAllowed()
coreymasanto May 25, 2022
a0750b1
Update AmpStory360.previewAllowed() to allow preview mode as long as …
coreymasanto May 25, 2022
3561551
Merge branch 'main' into previewCaptions360
coreymasanto Jun 2, 2022
0b60be0
Merge branch 'main' into previewCaptions360
coreymasanto Jun 8, 2022
8882dcb
Merge branch 'main' into previewCaptions360
coreymasanto Jun 8, 2022
b3299fd
Revert allowing amp-story-captions because ensuring its tracks use ca…
coreymasanto Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions extensions/amp-story-360/0.1/amp-story-360.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,16 @@ class CameraAnimation {
}

export class AmpStory360 extends AMP.BaseElement {
/** @override */
static previewAllowed(element) {
// We can assume that images are cached, but the same is not necessarily
// true for videos. We only allow preview mode for `AmpStory360` when it
// uses cached sources, because requests for origin sources cannot be made
// due to privacy concerns.
const usesVideo = element.querySelector('amp-video');
return !usesVideo;
}

/** @param {!AmpElement} element */
constructor(element) {
super(element);
Expand Down