Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract AMPPreactBaseElement #37309

Merged
merged 23 commits into from
Jan 20, 2022
Merged

Extract AMPPreactBaseElement #37309

merged 23 commits into from
Jan 20, 2022

Commits on Jan 18, 2022

  1. extract fn to register custom element

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    d5310bf View commit details
    Browse the repository at this point in the history

  2. create (empty) amp pbe

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    4508f14 View commit details
    Browse the repository at this point in the history

  3. inherit amp-accordion from amp-pbe

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    7c2a005 View commit details
    Browse the repository at this point in the history

  4. fix custom-element definitions for iframes (fixes tests)

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    39941d8 View commit details
    Browse the repository at this point in the history

  5. workarounds to properly test bento components 

    we don't want AMP.BaseElement to be declared so that it won't get injected into the class hierarchy. current tests assume that AMP should be initialized all the time which breaks bento tests
    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    0704b8c View commit details
    Browse the repository at this point in the history

  6. split out generic bento testing from amp tests 

    current (hacky) workarounds: some tests depend on CSS, which we expect consumers to install. This differs from the AMP components that register styles themselves. To workaround this we have to import and append the bento component styles. This problem might be unique to components that don't use shadowCss. For components that do use shadowDom and have critical styling that needs to be tested, those styles are already written in JSS and declared as shadowCss in the bento component's declaration, which ensures that that the styles are baked into the component.
    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    61ae6f5 View commit details
    Browse the repository at this point in the history

  7. Revert "workarounds to properly test bento components" 

    un-revert in order to test bento component
    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    6d4765c View commit details
    Browse the repository at this point in the history

  8. inherit all non-video bento-amp components from amp-pbe

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    fa48a80 View commit details
    Browse the repository at this point in the history

  9. rename VideoBaseElement -> AmpVideoBaseElement

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    dd0bdbd View commit details
    Browse the repository at this point in the history

  10. refactor inheritance hierarchy for video components to remove amp cod… 

    …e from bento hierarchy
    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    4e68348 View commit details
    Browse the repository at this point in the history

  11. fix amp-facebook hierarchy to preserve AmpFbBase functionality

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    e265420 View commit details
    Browse the repository at this point in the history

  12. update docs to demonstrate new way to scaffold amp-* components

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    5c4358e View commit details
    Browse the repository at this point in the history

  13. move (some) amp-specific methods into amp-pbe

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    93260f3 View commit details
    Browse the repository at this point in the history

  14. update dependencies, rename BentoVideoBaseElement

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    66c65e1 View commit details
    Browse the repository at this point in the history

  15. add doc

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    8d0c950 View commit details
    Browse the repository at this point in the history

  16. refactor dailymotion

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    1c77c72 View commit details
    Browse the repository at this point in the history

  17. ampvideobaseelement docs

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    bb3472e View commit details
    Browse the repository at this point in the history

  18. lint

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    aba612d View commit details
    Browse the repository at this point in the history

  19. fix typings and lint

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    6fa1130 View commit details
    Browse the repository at this point in the history

  20. remove file

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    1f74058 View commit details
    Browse the repository at this point in the history

  21. remove dict() based on ongoign discussions to deprecate

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    21f7876 View commit details
    Browse the repository at this point in the history

  22. disable local/restrict-this-access for the whole file

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    1fc0c59 View commit details
    Browse the repository at this point in the history

  23. remove more references to dict()

    @kvchari
    kvchari committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    d334290 View commit details
    Browse the repository at this point in the history