Core Typechecking: enable noImplicitAny #37201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
changed the title
samouri
force-pushed
the
noImplicitAny
branch
from
8809462
to
0786c79
Compare
rcebulko
reviewed
Dec 13, 2021
| @@ -128,8 +128,7 @@ export function isAmpMessage(message) { | |||
| ); | |||
| } | |||
|
|
|||
| /** @typedef {{creativeId: string, message: string}} */ | |||
| export let IframeTransportEventDef; | |||
| /** @typedef {{creativeId: string, message: string}} IframeTransportEventDef */ | |||
There was a problem hiding this comment.
Def as a suffix existed so we could lint-allow unused variables. For TS typing we can/should drop it
There was a problem hiding this comment.
🚲 time! I agree overall, but I view that as incredibly low priority. Low enough that I'd rather not make the change in this PR, and likely won't in followup PRs either. AFAIK there is no downside to keeping the Def in there.
rcebulko
reviewed
Dec 13, 2021
samouri
force-pushed
the
noImplicitAny
branch
from
0508e56
to
1e5176e
Compare
|
Hey @jridgewell! These files were changed: |
samouri
requested review from
jridgewell
and removed request for
kristoferbaxter
samouri
force-pushed
the
noImplicitAny
branch
from
3f09fa2
to
aa5da62
Compare
Co-authored-by: Ryan Cebulko <[email protected]>
samouri
force-pushed
the
noImplicitAny
branch
from
2a30653
to
479b2f3
Compare
rcebulko
approved these changes
Dec 13, 2021
jridgewell
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Enables the
noImplicitAnyoption for core tsconfig. There were a few changes necessary, and I am happy to bikeshed any of them:any. This required I then remove all the explicitimportstatement of those types, since they are not JS values.@constand@privateshorthand cannot be used for declaring types, and I switched them to using@type.ObjectorCSSStyleDeclarationsvia a string needed casting to any. Some I was able to fix via restructure, others seemed like too deep a well to solve (i.e.deepMerge). The logic for leaving as-is in this PR as that this doesn't make things perfect, but better than they were before (explicit any > implicit any).