♻️ #core/context pass TS type-checking #37185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jridgewell! These files were changed: |
samouri
reviewed
Dec 13, 2021
samouri
reviewed
Dec 13, 2021
| @@ -3,7 +3,6 @@ import { | |||
| reducer as loadingReducer, | |||
| } from '#core/constants/loading-instructions'; | |||
| import {contextProp} from '#core/context/prop'; | |||
| import {ContextPropDef} from '#core/context/prop.type'; | |||
There was a problem hiding this comment.
We'll likely need to add an import() comment later.
There was a problem hiding this comment.
Yes, but it'll also require updating the name everywhere in the file, so not bothering to update the whole file right now.
samouri
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #34096